php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #42 convert program dies on certain comments
Submitted: 1998-02-06 04:27 UTC Modified: 1998-02-06 12:59 UTC
From: a dot hacker at clear dot net dot nz Assigned:
Status: Closed Package: Other
PHP Version: 3.0b4 OS: Win32
Private report: No CVE-ID: None
 [1998-02-06 04:27 UTC] a dot hacker at clear dot net dot nz
Small niggly problem but I was converting a script I stumbled across and ran it through the PHP3->3 converter.
The converter died on comments ending in semi-colons like this
/* this is a comment */ ;

Don't know if it's a valid thing or just poor scripting but I thought I'd point it out. 

Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [1998-02-06 12:59 UTC] zeev
PHP/FI 2 accepted this, although IMHO it shouldn't have.  The convertor
'eats' the comment, and is left with a semicolon.  Since empty statements
weren't valid in PHP/FI 2, the convertor rejects that code.
It's possible to fix this specific issue, but it has potential to break
other things, so I'd rather not do it...

 [2019-08-22 14:24 UTC] curtiswrutzinger at icloud dot com
The following pull request has been associated:

Patch Name: Fix #78429: opcache_compile_file(__FILE__); segfaults
On GitHub:  https://github.com/php/php-src/pull/4570
Patch:      https://github.com/php/php-src/pull/4570.patch
 [2022-06-23 11:27 UTC] 24club at 24club dot com
The following pull request has been associated:

Patch Name: Enhancement: Add `.editorconfig`
On GitHub:  https://github.com/php/web-php/pull/554
Patch:      https://github.com/php/web-php/pull/554.patch
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Mar 19 08:01:29 2024 UTC